weizhouapache commented on PR #12758: URL: https://github.com/apache/cloudstack/pull/12758#issuecomment-4073183378
> Hello, @weizhouapache, all > > > We do not use the term "Native" in CloudStack > > Yes, we currently do not have any APIs using the term `Native`. But, this does not imply or require us to avoid using this expression when it is suitable. > > > Plugin names are typically based on the name of the external device or backup repository they integrate with. > > Yes, that is correct. In the case of the new backup plugin, it is fully implemented by ACS, including backup creation, chain management, compression, validation and other related processes. Therefore, its name is fully coherent with its functionality. In other words, KNIB (KVM Native Incremental Backup) stands for: > > * **KVM**: provides support for the KVM hypervisor; > * **Native**: Fully native to Apache CloudStack, i.e., all processes are implemented by the cloud platform orchestrator itself; > * **Incremental Backup**: Incremental backups are supported. > > > Please follow the same convention. > > Sorry, but is this a established convention? I am not aware of any guideline stating that the term `Native` is not supported. > > Again, if there is any semantic inconsistency with the plugin name KNIB (KVM Native Incremental Backup), we can address it. However, the plugin supports **incremental backups**, for **KVM**, **natively** in ACS; thus, the name accurately reflects what it delivers. It does not promote any concept or capability that is not actually provided. > > @JoaoJandre, btw, thanks for all the effort you put into designing and implementing this backup plugin. It will certainly be a stable and efficient solution, with strong adoption across cloud providers and users. I don’t want to continue debating this topic, so I’ll just summarize my view: - The mixed use of Secondary Storage is not a good approach. - The term "Native" is unclear and may confuse users. It would be better to follow the existing naming conventions used for other network/storage/backup plugins and choose a more descriptive name. - Please move API/DB/Java classes into the plugin as much as possible to keep the implementation isolated. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
