abh1sar commented on PR #12758: URL: https://github.com/apache/cloudstack/pull/12758#issuecomment-4135111333
> Hello, @abh1sar, @DaanHoogland, @weizhouapache, @yadvr, @vishesh92, and anyone interested > > To put a nail on the backup provider name, since KVM Native Incremental Backup is not ok according to you guys, could you tell me which provider name you think is most appropriate? > > 1. ACS KVM Backup Engine > 2. ACS KVM Backup Service > 3. KVM Incremental Backup Engine > 4. KVM Incremental Backup Service > 5. KVM Backup Engine > 6. KVM Backup Service > 7. ACS Embedded KVM Backup Engine > > If no opinion is given in the next week (Lazy consensus from the Apache Way), I will set the name as ACS KVM Backup Engine. HI @JoaoJandre About the name, I think functionality wise what distinguishes this provider from an existing KVM backup provider (NAS) is the use of secondary storage. So it makes some sense to use secondary storage in the name. So, probably something like Secondary Storage Backup Provider (BackupProviderPlugin value can be `secstore` in short) or KVM Secondary Storage Backup Provider ( BackupProviderPlugin value can be `kvmsecstore` in short). This seems more logical to me, but I don't have a hard preference on this matter. Will you be changing the term native/knib in the class files and configurations as well? Can I ask you to move all the files that don't have a strict dependency to be in the server module to plugins/backup/ ? Adding provider specific files in the server module is not really a good model if that can be avoided. server/src/main/java/org/apache/cloudstack/backup/BackupCompressionServiceJobController.java server/src/main/java/org/apache/cloudstack/backup/BackupValidationServiceController.java server/src/main/java/org/apache/cloudstack/backup/NativeBackupServiceImpl.java server/src/main/java/org/apache/cloudstack/backup/NativeBackupServiceJobController.java Also, what are these methods in NativeBackupServiceImpl for? I don't see a caller in the code. `orchestrateRestoreVMFromBackup` `orchestrateDeleteBackup` `orchestrateTakeBackup` `orchestrateRestoreBackupVolumeAndAttachToVM` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
