jmsperu commented on issue #12899: URL: https://github.com/apache/cloudstack/issues/12899#issuecomment-4143959951
Thanks @JoaoJandre, good points. 1. **`type` column** — agreed, we'll use the existing `backups.type` column to distinguish full vs incremental rather than adding a new one. 2. **Implementation-specific columns** — makes sense to keep the `backups` table provider-agnostic. We'll move `parent_backup_id`, `bitmap_name`, and `chain_id` to `backup_details` as key-value pairs. This also makes it easier for other backup providers to implement incremental in their own way without schema changes. I'll update the RFC to reflect this. Thanks for the review! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
