jmsperu commented on PR #12898: URL: https://github.com/apache/cloudstack/pull/12898#issuecomment-4178744719
@sureshanaparti Fixed. The test failures were caused by `overrideConfigValue()` in `NASBackupProviderTest` only setting `_value` on ConfigKey, but the zone-scoped configs (`valueIn(zoneId)`) fall back to `_defaultValue` when `s_depot` is null in the test context. All 5 config values (compression, bandwidth, encryption, encryption passphrase, integrity check) were returning null instead of the test values. The fix also sets `_defaultValue` via `ReflectionTestUtils` so `valueIn()` correctly resolves test values. Also addressed in the previous commit: replaced `2>&1 | tee -a` with `>> logFile 2>&1` in nasbackup.sh to prevent `tee` from masking non-zero exit codes, and added `return 1` after cleanup on virsh backup job failure. Could you please retrigger the build? `@blueorangutan package` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
