rp- commented on PR #12796: URL: https://github.com/apache/cloudstack/pull/12796#issuecomment-4199349231
> > Except for the large backup .qcow2 I have no further objections. > > I did some testing and found out that `qemu-img convert -O` used for stopped VM backups doesn't bloat the space. So for running VMs I added code in `nasbackup.sh` to use qemu-img convert -O on the backup file by creating a temp file and then replacing it with the backup file. > > There is no other way to avoid this with virsh backup-begin, so our best bet is to release the storage space after backup file is created. > > @rp- would you be able to verify the fix so that we can merge this in 4.22.1 before the freeze this Friday? Thanks. Just tested it now and looks good. Online-backups get compacted afterwards. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
