sureshanaparti commented on code in PR #12970:
URL: https://github.com/apache/cloudstack/pull/12970#discussion_r3055556488
##########
server/src/main/java/org/apache/cloudstack/vm/UnmanagedVMsManagerImpl.java:
##########
@@ -1970,6 +2026,13 @@ HostVO selectKVMHostForConversionInCluster(Cluster
destinationCluster, Long conv
err = String.format(
"Cannot perform the conversion on the host %s as it is
not in the same zone as the destination cluster",
selectedHost);
+ } else if (useVddk) {
+ hostDao.loadDetails(selectedHost);
+ if
(StringUtils.isBlank(selectedHost.getDetail(Host.HOST_VDDK_SUPPORT))) {
+ err = String.format(
+ "Cannot use VDDK-based conversion on host %s as
the '%s' is not there on the host",
+ selectedHost, Host.HOST_VDDK_SUPPORT);
Review Comment:
in some cases, agent is not restarted after updating vddk libs in the host,
so this detail can be blank, check it using CheckConvertInstanceCommand (in
_checkConversionSupportOnHost()_)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
