DaanHoogland commented on code in PR #12971:
URL: https://github.com/apache/cloudstack/pull/12971#discussion_r3056363496
##########
framework/jobs/src/main/java/org/apache/cloudstack/framework/jobs/impl/AsyncJobManagerImpl.java:
##########
@@ -1397,8 +1399,22 @@ protected AsyncJobManagerImpl() {
}
private void publishOnEventBus(AsyncJob job, String jobEvent) {
- _messageBus.publish(null, AsyncJob.Topics.JOB_EVENT_PUBLISH,
PublishScope.LOCAL,
- new Pair<AsyncJob, String>(job, jobEvent));
+ try {
+ _eventBusPublisher.submit(new ManagedContextRunnable() {
+ @Override
+ protected void runInContext() {
+ try {
+ _messageBus.publish(null,
AsyncJob.Topics.JOB_EVENT_PUBLISH, PublishScope.LOCAL,
+ new Pair<>(job, jobEvent));
+ } catch (Throwable t) {
+ logger.warn("Failed to publish async job event on
message bus. jobId={}, jobEvent={}",
+ job != null ? job.getId() : null, jobEvent, t);
+ }
+ }
+ });
+ } catch (RejectedExecutionException e) {
+ logger.warn("Failed to publish async job event, event bus
publisher is shut down", e);
+ }
Review Comment:
nested try catch block, can you make a new method for the inner one?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
