DaanHoogland commented on code in PR #12951:
URL: https://github.com/apache/cloudstack/pull/12951#discussion_r3063180409
##########
ui/src/views/offering/AddNetworkOffering.vue:
##########
@@ -681,7 +691,8 @@ export default {
isolation: 'dedicated',
conservemode: true,
availability: 'optional',
- egressdefaultpolicy: 'deny',
+ specifyipranges: false,
+ egressdefaultpolicy: 'allow',
Review Comment:
@Tonitzpp , i have my doubts about this part of the change. Someone decided
that it is better to deny outgoing traffic be default (for UI users) and that
seems reasonable to me. No reason to allign UI and API on this I think as API
users are usually better versed at hardening their VMs/networks. If allignment
is strictly necessary (not to me) I think we should change the API on this
point, in another PR. What do you think?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
