DaanHoogland commented on code in PR #13022:
URL: https://github.com/apache/cloudstack/pull/13022#discussion_r3084300524
##########
api/src/main/java/org/apache/cloudstack/api/command/admin/acl/project/ListProjectRolesCmd.java:
##########
@@ -72,7 +72,10 @@ public String getRoleName() {
@Override
public void execute() {
- List<ProjectRole> projectRoles = new ArrayList<>();
+ if (getProjectId() != null &&
_projectService.getProject(getProjectId()) == null) {
Review Comment:
I think the special case `projectId = -1` is neglected this way. It looks
like it is not applicable for `ListProjectRoles`, but in general that value is
allowed. Can you check how to handle it?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
