bhouse-nexthop commented on code in PR #12859:
URL: https://github.com/apache/cloudstack/pull/12859#discussion_r3087070634
##########
systemvm/debian/opt/cloud/bin/cs/CsAddress.py:
##########
@@ -584,6 +584,37 @@ def fw_vpcrouter(self):
"-A PREROUTING -m state --state NEW -i %s -s
%s ! -d %s/32 -j ACL_OUTBOUND_%s" %
(self.dev, guestNetworkCidr,
self.address['gateway'], self.dev)])
+ # Process static routes for this interface
Review Comment:
a vast majority of this block was just moved up outside of the `if
self.is_private_gateway():`, I don't think it warrants a helper function tbh.
Plus, the code as it is right now has been well tested, so we'd have to go
through the validation process again.
If you feel really strongly about it I'll do it, but I'd rather not :)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
