GaOrtiga commented on code in PR #12645:
URL: https://github.com/apache/cloudstack/pull/12645#discussion_r3093957288
##########
ui/public/locales/en.json:
##########
@@ -3731,6 +3731,7 @@
"message.warn.filetype": "jpg, jpeg, png, bmp and svg are the only supported
image formats.",
"message.warn.importing.instance.without.nic": "WARNING: This Instance is
being imported without NICs and many Network resources will not be available.
Consider creating a NIC via vCenter before importing or as soon as the Instance
is imported.",
"message.warn.zone.mtu.update": "Please note that this limit won't affect
pre-existing Network's MTU settings",
+"message.warn.vpc.offerings": "VPC offerings will be shown only if the
selected account has at least one VPC.",
Review Comment:
```suggestion
"message.warn.vpc.offerings": "VPC offerings will only be shown if the
selected account has at least one VPC.",
```
##########
ui/src/views/network/CreateIsolatedNetworkForm.vue:
##########
@@ -515,13 +521,17 @@ export default {
if (this.vpc !== null) { // from VPC section
this.fetchNetworkOfferingData(true)
} else { // from guest network section
- var params = {}
+ var params = {
+ account: this.owner.account,
+ projectid: this.owner.projectid,
+ domainid: this.owner.domainid
+ }
this.networkOfferingLoading = true
if ('listVPCs' in this.$store.getters.apis) {
api('listVPCs', params).then(json => {
const listVPCs = json.listvpcsresponse.vpc
- var vpcAvailable = this.arrayHasItems(listVPCs)
- if (vpcAvailable === false) {
+ this.hasVPC = this.arrayHasItems(listVPCs)
+ if (this.hasVPC === false) {
this.fetchNetworkOfferingData(false)
} else {
this.fetchNetworkOfferingData()
Review Comment:
```suggestion
this.fetchNetworkOfferingData(this.hasVPC)
```
##########
ui/public/locales/pt_BR.json:
##########
@@ -2510,6 +2510,7 @@
"message.vr.alert.upon.network.offering.creation.others": "Como nenhum dos
servi\u00e7os obrigat\u00f3rios para cria\u00e7\u00e3o do VR (VPN, DHCP, DNS,
Firewall, LB, UserData, SourceNat, StaticNat, PortForwarding) foram
habilitados, o VR n\u00e3o ser\u00e1 criado e a oferta de computa\u00e7\u00e3o
n\u00e3o ser\u00e1 usada.",
"message.warn.filetype": "jpg, jpeg, png, bmp e svg s\u00e3o os \u00fanicos
formatos de imagem suportados",
"message.warn.importing.instance.without.nic": "AVISO: essa inst\u00e2ncia
est\u00e1 sendo importada sem NICs e muitos recursos de rede n\u00e3o
estar\u00e3o dispon\u00edveis. Considere criar uma NIC antes de importar via
VCenter ou assim que a inst\u00e2ncia for importada.",
+"message.warn.vpc.offerings": "Ofertas de VPC s\u00c3o exibidas somente caso a
conta selecionada possua ao menos uma VPC.",
Review Comment:
```suggestion
"message.warn.vpc.offerings": "Ofertas de VPC somente ser\u00c3o exibidas
caso a conta selecionada possua ao menos uma VPC.",
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]