DaanHoogland commented on code in PR #13021:
URL: https://github.com/apache/cloudstack/pull/13021#discussion_r3098445462
##########
server/src/main/java/com/cloud/consoleproxy/ConsoleProxyManagerImpl.java:
##########
@@ -1525,12 +1525,9 @@ public boolean isPoolReadyForScan(Long dataCenterId) {
return false;
}
- List<ConsoleProxyVO> l =
consoleProxyDao.getProxyListInStates(State.Starting, State.Stopping);
- if (l.size() > 0) {
- if (logger.isDebugEnabled()) {
- logger.debug("Zone {} has {} console proxy VM(s) in transition
state", zone, l.size());
- }
-
+ List<ConsoleProxyVO> l =
consoleProxyDao.getProxyListInStates(dataCenterId, State.Starting,
State.Stopping);
+ if (!l.isEmpty()) {
+ logger.debug("Zone {} has {} console proxy VM(s) in transition
state.", zone, l.size());
Review Comment:
@Tonitzpp , I agree that it is better to use descriptive names for all
fields and veriables. Will you apply this suggestion?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
