harikrishna-patnala commented on code in PR #12911:
URL: https://github.com/apache/cloudstack/pull/12911#discussion_r3145677513
##########
plugins/ca/root-ca/src/main/java/org/apache/cloudstack/ca/provider/RootCAProvider.java:
##########
@@ -106,17 +106,22 @@ public final class RootCAProvider extends AdapterBase
implements CAProvider, Con
private static ConfigKey<String> rootCAPrivateKey = new
ConfigKey<>("Hidden", String.class,
"ca.plugin.root.private.key",
null,
- "The ROOT CA private key.", true);
+ "The ROOT CA private key in PEM format. " +
+ "When set along with the public key and certificate, CloudStack
uses this custom CA instead of auto-generating one. " +
+ "All three ca.plugin.root.* keys must be set together. Restart
management server(s) when changed.", true);
Review Comment:
the config says it is dynamic but comment says restart MS is required !!!
##########
plugins/ca/root-ca/src/main/java/org/apache/cloudstack/ca/provider/RootCAProvider.java:
##########
@@ -106,17 +106,22 @@ public final class RootCAProvider extends AdapterBase
implements CAProvider, Con
private static ConfigKey<String> rootCAPrivateKey = new
ConfigKey<>("Hidden", String.class,
"ca.plugin.root.private.key",
null,
- "The ROOT CA private key.", true);
+ "The ROOT CA private key in PEM format. " +
+ "When set along with the public key and certificate, CloudStack
uses this custom CA instead of auto-generating one. " +
+ "All three ca.plugin.root.* keys must be set together. Restart
management server(s) when changed.", true);
private static ConfigKey<String> rootCAPublicKey = new
ConfigKey<>("Hidden", String.class,
"ca.plugin.root.public.key",
null,
- "The ROOT CA public key.", true);
+ "The ROOT CA public key in PEM format (X.509/SPKI: must start with
'-----BEGIN PUBLIC KEY-----'). " +
Review Comment:
same as above !
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
