dheeraj12347 commented on PR #12967: URL: https://github.com/apache/cloudstack/pull/12967#issuecomment-4347980651
> > > @dheeraj12347 , I see a lot of extra new-lines. Are those needed? > > > > > > I’ve removed the extra blank lines and fixed indentation in all four log4j XML files, keeping the stderr timestamp changes and other logging behavior unchanged. These are the extra lines you are talking about ? > > yes @dheeraj12347 , sorry for the silence I have been quiet busy last week. i now see java code touched in this PR. Is that intended? Thanks for the follow‑up, Daan. Yes, the Java change is intentional, but it’s small and related to the same diagnostics/console behaviour I was looking at while working on the .err timestamping and console‑proxy troubleshooting, not an unrelated feature. Right now this PR’s main focus is still the log4j configuration changes for management/server/agent/usage to add timestamps to .err as discussed in #12887, and the Java touch is only in that console‑proxy path that affects how we see and debug console behaviour. If you’d prefer this PR to be strictly scoped to the log4j XML changes, I can drop the Java hunk here and move it into a separate, dedicated PR with its own explanation and tests. Just let me know which way you’d rather have it. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
