weizhouapache commented on code in PR #13108:
URL: https://github.com/apache/cloudstack/pull/13108#discussion_r3199721171
##########
plugins/hypervisors/kvm/src/main/java/com/cloud/hypervisor/kvm/resource/LibvirtComputingResource.java:
##########
@@ -3028,8 +3028,10 @@ public void createVifs(final VirtualMachineTO vmSpec,
final LibvirtVMDef vm) thr
final NicTO[] nics = vmSpec.getNics();
final Map <String, String> params = vmSpec.getDetails();
String nicAdapter = "";
- if (params != null && params.get("nicAdapter") != null &&
!params.get("nicAdapter").isEmpty()) {
- nicAdapter = params.get("nicAdapter");
+ if (params != null && params.get(VmDetailConstants.NIC_ADAPTER) !=
null && !params.get(VmDetailConstants.NIC_ADAPTER).isEmpty()) {
+ nicAdapter = params.get(VmDetailConstants.NIC_ADAPTER);
+ } else if (MapUtils.isNotEmpty(params) &&
params.containsKey(GuestDef.BootType.UEFI.toString())) {
+ nicAdapter = "e1000";
Review Comment:
@harikrishna-patnala
yeah, documentation may be good. user can choose nic adaptor when deploy a
vm.
optionally, we could add the option in the vm deployment wizard on UI, which
is not available now.
<img width="2220" height="569" alt="image"
src="https://github.com/user-attachments/assets/3f136f16-80b4-4ecb-ae09-d1b6d941edf3";
/>
I do no know if "rtl813" is fine.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
