weizhouapache commented on PR #13127:
URL: https://github.com/apache/cloudstack/pull/13127#issuecomment-4407996145
> its worked with your sugestion.@weizhouapache
>
> File "/opt/cloud/bin/cs/CsVpcGuestNetwork.py", line 110, in add_radvd_conf
if entry['router_guest_ip6'] == entry['router_guest_ip6_gateway'] or
self.config.is_redundant(): ^^^^^^^^^^^^^^^^^^^^^^^^ AttributeError: 'CsConfig'
object has no attribute 'is_redundant'
>
> I've updated the PR with your suggested fix, with a tiny syntactic tweak:
`is_redundant()` is defined on `CsCmdLine`, not `CsConfig`, so the call should
go through `self.cl` (which `CsDataBag.__init__` already exposes via `self.cl =
config.cmdline()`). This matches the idiom used elsewhere in the systemvm
scripts (CsDhcp, CsRedundant, CsAddress, etc.):
>
> ```python
> if entry['router_guest_ip6'] == entry['router_guest_ip6_gateway'] or
self.cl.is_redundant():
> self.conf.append(" prefix %s" % full_addr)
> ...
> ```
great, thanks for the fix and updating the PR
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
