winterhazel commented on code in PR #13019: URL: https://github.com/apache/cloudstack/pull/13019#discussion_r3238345952
########## engine/schema/src/main/java/com/cloud/upgrade/dao/Upgrade42030to42040.java: ########## @@ -0,0 +1,58 @@ +// Licensed to the Apache Software Foundation (ASF) under one Review Comment: @abh1sar understood. In this case, I think that we can proceed with this fix. I also saw now that the `createVMHelperEvent()` already has a logic for preventing two active entries for the same instance simultaneously, which means that there would not be duplicate usage record generation even if there was no `VM.STOP` between. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
