Damans227 commented on PR #12813: URL: https://github.com/apache/cloudstack/pull/12813#issuecomment-4493824730
> clgtm, but a concern remains (might be mute): Are we sure, when marking the snapshots records, there are really no data files left on primary for those? I do not see any code ensuring that. Good catch @DaanHoogland fixed. Cleanup now routes through `_snapshotService.deleteSnapshot(...)` so the storage driver actually removes the data, and the parent snapshots row only flips to Destroyed after confirming no live store refs remain. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
