Pearl1594 commented on code in PR #13202:
URL: https://github.com/apache/cloudstack/pull/13202#discussion_r3281118961
##########
server/src/main/java/com/cloud/consoleproxy/ConsoleProxyManager.java:
##########
@@ -87,12 +87,13 @@ public interface ConsoleProxyManager extends Manager,
ConsoleProxyService {
ConfigKey<Integer> ConsoleProxyLaunchMax = new ConfigKey<>(Integer.class,
"consoleproxy.launch.max", "Console Proxy", "10",
"maximum number of console proxy instances per zone can be
launched", false, ConfigKey.Scope.Zone, null);
- String consoleProxyManagementStates =
Arrays.stream(com.cloud.consoleproxy.ConsoleProxyManagementState.values()).map(Enum::name).collect(Collectors.joining(","));
- ConfigKey<String> ConsoleProxyServiceManagementState = new
ConfigKey<String>(ConfigKey.CATEGORY_ADVANCED, String.class,
"consoleproxy.management.state",
com.cloud.consoleproxy.ConsoleProxyManagementState.Auto.toString(),
- "console proxy service management state", false,
ConfigKey.Kind.Select, consoleProxyManagementStates);
+ String consoleProxyServiceManagementStates =
Arrays.stream(com.cloud.consoleproxy.ConsoleProxyManagementState.values()).map(Enum::name).collect(Collectors.joining(","));
- ConfigKey<String> ConsoleProxyManagementLastState = new
ConfigKey<String>(ConfigKey.CATEGORY_ADVANCED, String.class,
"consoleproxy.management.state.last",
com.cloud.consoleproxy.ConsoleProxyManagementState.Auto.toString(),
- "last console proxy service management state", false,
ConfigKey.Kind.Select, consoleProxyManagementStates);
+ ConfigKey<String> ConsoleProxyServiceManagementState = new
ConfigKey<>(ConfigKey.CATEGORY_ADVANCED, String.class,
"consoleproxy.management.state",
com.cloud.consoleproxy.ConsoleProxyManagementState.Auto.toString(),
+ "console proxy service management state", true,
ConfigKey.Kind.Select, consoleProxyServiceManagementStates);
+
+ ConfigKey<String> ConsoleProxyServiceManagementLastState = new
ConfigKey<>(ConfigKey.CATEGORY_ADVANCED, String.class,
"consoleproxy.management.state.last",
com.cloud.consoleproxy.ConsoleProxyManagementState.Auto.toString(),
+ "last console proxy service management state", true,
ConfigKey.Kind.Select, consoleProxyServiceManagementStates);
Review Comment:
Should we move these to Zone scope as we have done with most of the Console
proxy related settings?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
