jmsperu commented on PR #13074: URL: https://github.com/apache/cloudstack/pull/13074#issuecomment-4522732600
Thanks @harikrishna-patnala @abh1sar — pushed 4 commits addressing the feedback: - `9f4d61f31c` — drop unused `host.getId()` stub in `deleteWithLiveChildMarksDeletePendingAndPreservesFile` (fixes the UnnecessaryStubbingException Harikrishna flagged) - `691931de23` — add `nas.backup.incremental.enabled` ConfigKey (abh1sar review thread @ line 90) - `0bdcdb1484` — pre-seed bitmap on stopped-VM backup via `qemu-img bitmap --add` so the next backup can be incremental (abh1sar review thread @ nasbackup.sh:513) - `5be1910ff0` — per-volume parent paths: `TakeBackupCommand.parentPath` -> `parentPaths: List<String>`, script rebases each disk onto its own parent file, falls back to fresh full when current/parent volume counts don't match (abh1sar review thread @ line 340) All 14 unit tests pass locally. Could one of you trigger `@blueorangutan test` once GHA goes green? Happy to address any further review comments. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
