jmsperu commented on PR #12900: URL: https://github.com/apache/cloudstack/pull/12900#issuecomment-4523012657
Pushed the scope reduction discussed above. - New `nas.infra.backup.include.database` global, **default false** — DB component is fully gated on it. Configs + certs path runs regardless. - Updated `nas.infra.backup.enabled` description to make the new split explicit and steer production users to the cron-job approach for the DB. - Added `InfrastructureBackupTaskTest` (9 tests, all passing locally) covering the gating decisions — should materially close the codecov gap @weizhouapache flagged. - Refactored a few methods to `protected` so the side-effecting paths (mysqldump, tar) can be overridden in tests without standing up real ProcessBuilders. Ready for another look. If you'd still rather drop the DB component entirely and ship configs+certs only, happy to do that in a follow-up — let me know. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
