andrijapanicsb opened a new pull request, #13240: URL: https://github.com/apache/cloudstack/pull/13240
### Description This PR clarifies the wording for the optional public IPv4 address assigned to virtual routers during isolated network and VPC creation. The existing `label.routerip` text was reused for `sourcenatipaddress` in the isolated network and VPC forms, where the value represents the optional public interface / Source NAT address of the VR. The old wording, `IPv4 address for the VR in this Network`, could be confused with the internal router IP or gateway address. The label now reads `Public IPv4 address for the VR`. The API descriptions for `sourcenatipaddress` are also updated to explicitly describe the value as optional and assigned to the public interface. The VPC API wording now refers to the VPC router and VPC implementation rather than a generic Network router/implementation. Shared network router IP fields are not necessarily public. To avoid changing their meaning, `CreateSharedNetworkForm.vue` now uses the dedicated shared-network labels, `label.sharedrouterip` and `label.sharedrouteripv6`, instead of the generic `label.routerip` and `label.routeripv6`. This keeps shared network creation wording unchanged while allowing the generic label to be accurate for the Source NAT/public VR address fields. No functional behavior is changed; this is a UI/API-description wording improvement only. ### Types of changes - [ ] Breaking change (fix or feature that would cause existing functionality to change) - [ ] New feature (non-breaking change which adds functionality) - [ ] Bug fix (non-breaking change which fixes an issue) - [x] Enhancement (improves an existing feature and functionality) - [ ] Cleanup (Code refactoring and cleanup, that may add test cases) - [ ] Build/CI - [ ] Test (unit or integration test code) ### Feature/Enhancement Scale or Bug Severity #### Feature/Enhancement Scale - [ ] Major - [x] Minor #### Bug Severity - [ ] BLOCKER - [ ] Critical - [ ] Major - [ ] Minor - [ ] Trivial ### Screenshots (if appropriate): N/A ### How Has This Been Tested? - Parsed `ui/public/locales/en.json` successfully. - Ran `git diff --check` on the changed files. - Verified shared network creation uses `label.sharedrouterip` and `label.sharedrouteripv6`, so shared network router IP fields do not inherit the new public IPv4 wording. #### How did you try to break this feature and the system with this change? Checked each use of the affected labels in the network creation views to confirm the public wording is only used by the `sourcenatipaddress` fields in isolated network and VPC creation, while shared network creation retains dedicated shared-network labels. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
