weizhouapache commented on code in PR #13032:
URL: https://github.com/apache/cloudstack/pull/13032#discussion_r3304604054
##########
engine/orchestration/src/main/java/org/apache/cloudstack/engine/orchestration/NetworkOrchestrator.java:
##########
@@ -461,6 +469,28 @@ public void setDhcpProviders(final
List<DhcpServiceProvider> dhcpProviders) {
HashMap<Long, Long> _lastNetworkIdsToFree = new HashMap<>();
+ /**
+ * Returns the full list of network elements to iterate when implementing,
+ * shutting down, or otherwise orchestrating a network.
+ *
+ * <p>The base list ({@link #networkElements}, wired by Spring) is extended
+ * at runtime with one transient {@link NetworkExtensionElement} per
+ * registered {@code NetworkOrchestrator} extension. This keeps the
+ * Spring bean list free from {@code NetworkExtensionElement} and allows
+ * dynamic discovery of extensions without a restart.</p>
+ */
+ private List<NetworkElement> getNetworkElementsIncludingExtensions() {
+ List<Extension> extensions =
extensionHelper.listExtensionsByType(Extension.Type.NetworkOrchestrator);
+ if (extensions == null || extensions.isEmpty()) {
Review Comment:
make sense, thanks
done
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
