Tonitzpp opened a new pull request, #13287: URL: https://github.com/apache/cloudstack/pull/13287
### Description The `externalId` parameter of the `createNetwork` API was initially introduced to add support for networks managed by Nuage in Apache CloudStack. Nuage was a network plugin that was supported by ACS, but the support was discontinued in 2019 (see https://github.com/apache/cloudstack/pull/3622) and the parameter was left unused. Therefore, this PR removes the `externalId` parameter in `createNetwork` API and in the UI. ### Types of changes - [ ] Breaking change (fix or feature that would cause existing functionality to change) - [ ] New feature (non-breaking change which adds functionality) - [ ] Bug fix (non-breaking change which fixes an issue) - [ ] Enhancement (improves an existing feature and functionality) - [X] Cleanup (Code refactoring and cleanup, that may add test cases) - [ ] Build/CI - [ ] Test (unit or integration test code) ### Feature/Enhancement Scale or Bug Severity #### Feature/Enhancement Scale - [ ] Major - [X] Minor ### Screenshots (if appropriate): ### How Has This Been Tested? To perform the testes, I opened the `createNetwork` form in GUI and checked that the `externalId` parameter isn't present in the form anymore. Via CMK, I checked that the `externalId` parameter isn't present in the `createNetwork` API too. Then, I created a new Network and created a new VM with it. No problems have been found in the process. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
