weizhouapache commented on PR #13032: URL: https://github.com/apache/cloudstack/pull/13032#issuecomment-4609709916
thanks a lot @vishesh92 for the review, very good comments I will look into the following - check if prepare and release nic can be improved - check setExtraDhcpOptions if nic_id is needed - check if nic_uuid can be replaced with nic_id (I guess no) - take ipv6 address nto consideratoin - pass some data in jsonobject, instead of building json string - discard base64 encoding (for legacy CLI) and remove jsonEscape method - check resolveExtensionForVpc in a zone with multiple physical networks - introduce an isolation method: Extension -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
