bernardodemarco commented on code in PR #13288:
URL: https://github.com/apache/cloudstack/pull/13288#discussion_r3365589021
##########
api/src/main/java/org/apache/cloudstack/api/command/user/resource/ListResourceLimitsCmd.java:
##########
@@ -54,7 +54,8 @@ public class ListResourceLimitsCmd extends
BaseListProjectAndAccountResourcesCmd
+ "8 - CPU. Number of CPU an account can allocate for their resources.
"
+ "9 - Memory. Amount of RAM an account can allocate for their
resources. "
+ "10 - PrimaryStorage. Total primary storage space (in GiB) a user
can use. "
- + "11 - SecondaryStorage. Total secondary storage space (in GiB) a
user can use. ")
+ + "11 - SecondaryStorage. Total secondary storage space (in GiB) a
user can use. "
+ + "12 - instanceSnapshot. Number of instance snapshots an account can
own.")
Review Comment:
```suggestion
+ "12 - InstanceSnapshot. Number of instance snapshots an account
can own.")
```
##########
api/src/main/java/com/cloud/configuration/Resource.java:
##########
@@ -30,6 +30,7 @@ enum ResourceType { // Primary and Secondary storage are
allocated_storage and n
project("project", 5),
network("network", 6),
vpc("vpc", 7),
+ instance_snapshot("instance_snapshot", 12),
Review Comment:
We could move this line after the `secondary_storage("secondary_storage",
11)` option
##########
api/src/main/java/org/apache/cloudstack/api/response/ProjectResponse.java:
##########
@@ -188,6 +188,18 @@ public class ProjectResponse extends BaseResponse
implements ResourceLimitAndCou
@Param(description = "The total number of Snapshots available for this
project", since = "4.2.0")
private String snapshotAvailable;
+ @SerializedName(ApiConstants.VM_SNAPSHOT_LIMIT)
+ @Param(description = "the number of Instance Snapshots that can be stored
by this Project")
Review Comment:
just to maintain consistency with the other descriptions of this response
class
```suggestion
@Param(description = "the number of Instance Snapshots that can be
stored by this project")
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
