abh1sar commented on code in PR #13229:
URL: https://github.com/apache/cloudstack/pull/13229#discussion_r3408083452
##########
server/src/main/java/org/apache/cloudstack/backup/BackupManagerImpl.java:
##########
@@ -441,6 +441,13 @@ public boolean assignVMToBackupOffering(Long vmId, Long
offeringId) {
throw new CloudRuntimeException("VM is not in running or stopped
state");
}
+ List<VolumeVO> volumes = volumeDao.findByInstance(vmId);
+ for (VolumeVO volume : volumes) {
+ if (volume != null && volume.getPassphraseId() != null) {
+ throw new CloudRuntimeException("VM has encrypted volumes,
backup offering assignment is not allowed");
+ }
+ }
+
Review Comment:
Move this to NasBackupProvider.java in
backupProvider.assignVMToBackupOffering.
We want to disable backup for encrypted volume for just nas backup provider.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
