daviftorres commented on code in PR #13424:
URL: https://github.com/apache/cloudstack/pull/13424#discussion_r3453469589
##########
scripts/vm/hypervisor/kvm/nasbackup.sh:
##########
@@ -196,10 +196,12 @@ backup_running_vm() {
# Print statistics
virsh -c qemu:///system domjobinfo $VM --completed
- du -sb $dest | cut -f1
-
- umount $mount_point
- rmdir $mount_point
+ backup_size=$(du -sb "$dest" 2>/dev/null | cut -f1) || true
+
+ timeout 60 umount "$mount_point" 2>/dev/null || true
+ rmdir "$mount_point" 2>/dev/null || true
+
Review Comment:
If a human reviewer believes Copilot's suggestions are valuable
(particularly the change on line 199), I'm open to applying them.
Otherwise, I'll stick to the initial scope: only preventing the exit status
from nullifying a successful backup.
Introducing additional fixes to the shell script could potentially mask
unanticipated conditions that aren't properly handled on the Java side.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
