Copilot commented on code in PR #13032:
URL: https://github.com/apache/cloudstack/pull/13032#discussion_r3504197833
##########
tools/marvin/setup.py:
##########
@@ -46,7 +46,7 @@
"marvin.sandbox.basic"],
license="LICENSE.txt",
install_requires=[
- "mysql-connector-python <= 8.4.0",
+ "mysql-connector-python >= 8.4.0",
"requests >= 2.2.1",
"paramiko >= 1.13.0",
Review Comment:
`mysql-connector-python >= 8.4.0` is not installable on Python 2, but this
repo still includes a Python 2-based Marvin Dockerfile
(`tools/docker/Dockerfile.marvin`) that installs the Marvin tarball. With the
current requirement, `pip install Marvin-*.tar.gz` will fail in that
environment. If Python 2 support is still expected here, make the dependency
conditional by Python version (or update the Dockerfile in the same PR).
##########
ui/src/views/offering/AddVpcOffering.vue:
##########
@@ -647,7 +624,7 @@ export default {
if (service === 'SourceNat') {
this.sourceNatServiceChecked = checked
}
- if (checked && provider != null & provider !== undefined) {
+ if (checked && provider != null && provider !== undefined) {
Review Comment:
The condition `provider != null && provider !== undefined` is redundant:
`provider != null` already excludes both `null` and `undefined`. Simplifying
this avoids confusion and keeps the check consistent with the rest of the
codebase.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
