weizhouapache commented on code in PR #13332:
URL: https://github.com/apache/cloudstack/pull/13332#discussion_r3542112316
##########
server/src/main/java/org/apache/cloudstack/backup/BackupManagerImpl.java:
##########
@@ -1822,12 +1822,9 @@ public BackupProvider getBackupProvider(final Long
zoneId) {
}
public BackupProvider getBackupProvider(final String name) {
- if (StringUtils.isEmpty(name)) {
- throw new CloudRuntimeException("Invalid backup provider name
provided");
- }
- if (!backupProvidersMap.containsKey(name)) {
- throw new CloudRuntimeException("Failed to find backup provider by
the name: " + name);
- }
Review Comment:
@yigitbasalma
I think these checks are fine here, no need to remove
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
