winterhazel commented on code in PR #13449:
URL: https://github.com/apache/cloudstack/pull/13449#discussion_r3546081552


##########
plugins/database/quota/src/main/java/org/apache/cloudstack/api/command/QuotaCreditsListCmd.java:
##########
@@ -116,7 +124,10 @@ public void execute() {
 
     @Override
     public long getEntityOwnerId() {
-        return -1;
+        if (ObjectUtils.allNull(accountId, projectId)) {
+            return -1;
+        }
+        return _accountService.finalizeAccountId(accountId, null, null, 
projectId);

Review Comment:
   > What happens if both accountId and projectId are specified together
   
   An exception saying that they cannot be specified together is thrown.
   
   > And, we have access validation to these parameters, right?
   
   Yes, same answer as 
https://github.com/apache/cloudstack/pull/13236#discussion_r3319152214



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to