Copilot commented on code in PR #13615:
URL: https://github.com/apache/cloudstack/pull/13615#discussion_r3580592126
##########
api/src/main/java/org/apache/cloudstack/api/command/admin/network/NetworkOfferingBaseCmd.java:
##########
@@ -430,9 +432,8 @@ public Map<Network.Capability, String>
getServiceCapabilities(Network.Service se
public Map<String, String> getDetails() {
if (details == null || details.isEmpty()) {
- return null;
+ return sourceDetailsMap;
}
Review Comment:
`getDetails()` now falls back to returning `sourceDetailsMap` when the API
`details` parameter is missing/empty (used by clone flow). There’s no unit test
covering this new behavior, so regressions could reintroduce the previous
`ClassCastException` scenario or silently drop cloned details. Please add a
test that (a) sets `sourceDetailsMap` via reflection and asserts `getDetails()`
returns it when `details` is null/empty, and (b) ensures normal `details`
parsing still takes precedence when `details` is provided.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
