DaanHoogland commented on code in PR #13696:
URL: https://github.com/apache/cloudstack/pull/13696#discussion_r3649897787
##########
plugins/integrations/prometheus/src/main/java/org/apache/cloudstack/metrics/PrometheusExporterServerImpl.java:
##########
@@ -108,6 +113,10 @@ public boolean stop() {
httpServer.stop(0);
logger.debug("Stopped Prometheus exporter http server");
}
+ if (httpExecutor != null) {
+ httpExecutor.shutdownNow();
+ logger.debug("Shut down Prometheus exporter http executor");
+ }
Review Comment:
should `httpExecutor` also be set to null on `httpServer`?
something like
```suggestion
if (httpExecutor != null) {
httpExecutor.shutdownNow();
logger.debug("Shut down Prometheus exporter http executor");
}
httpServer.setExecutor(null); // ¡¡¡¡¡Did not test!!!!!
```
?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
