DaanHoogland commented on code in PR #13379:
URL: https://github.com/apache/cloudstack/pull/13379#discussion_r3656699498
##########
plugins/hypervisors/kvm/src/main/java/com/cloud/hypervisor/kvm/resource/BridgeVifDriver.java:
##########
@@ -186,9 +186,16 @@ protected boolean isValidProtocolAndVnetId(final String
vNetId, final String pro
protected String createStorageVnetBridgeIfNeeded(NicTO nic, String
trafficLabel,
String storageBrName) throws InternalErrorException {
- if
(!Networks.BroadcastDomainType.Storage.equals(nic.getBroadcastType()) ||
nic.getBroadcastUri() == null) {
+ if (nic.getBroadcastUri() == null) {
return storageBrName;
}
+
+ boolean isStorageBroadcast =
Networks.BroadcastDomainType.Storage.equals(nic.getBroadcastType()) ||
+
Networks.BroadcastDomainType.Storage.equals(Networks.BroadcastDomainType.getSchemeValue(nic.getBroadcastUri()));
+ if (!isStorageBroadcast) {
+ return storageBrName;
+ }
Review Comment:
both branches
```
return storageBrName;
```
This is a bit confusing. Can you unify them @Pearl1594 ?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
