DaanHoogland commented on code in PR #13719:
URL: https://github.com/apache/cloudstack/pull/13719#discussion_r3659055252
##########
server/src/main/java/com/cloud/resource/ResourceManagerImpl.java:
##########
@@ -3213,9 +3216,61 @@ private HostVO getNewHost(StartupCommand[]
startupCommands) {
}
logger.debug(String.format("Could not find Host by guid %s",
fullGuid));
+
+ // No live host matches this GUID. Before letting the caller create a
brand-new host,
+ // make sure this GUID does not belong to a host that was previously
deleted. Otherwise a
+ // still-running agent whose host was deleted would silently
re-register itself as a new host.
Review Comment:
I agree that the `silently` part is undesirable, but how about the
intentional move of a host?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
