Copilot commented on code in PR #13733:
URL: https://github.com/apache/cloudstack/pull/13733#discussion_r3664634342
##########
server/src/main/java/com/cloud/storage/snapshot/SnapshotManagerImpl.java:
##########
@@ -1528,13 +1528,13 @@ private Type getSnapshotType(IntervalType intvType) {
return null;
}
- private boolean hostSupportsSnapsthotForVolume(HostVO host, VolumeInfo
volume, boolean isFromVmSnapshot) {
+ private boolean hostSupportsSnapshotForVolume(HostVO host, VolumeInfo
volume, boolean isFromVmSnapshot) {
if (host.getHypervisorType() != HypervisorType.KVM) {
return true;
}
- //Turn off snapshot by default for KVM if the volume attached to vm
that is not in the Stopped/Destroyed state,
- //unless it is set in the global flag
+ // For KVM, snapshots of a volume attached to a vm that is not in the
Stopped/Destroyed state are allowed
+ // unless the global flag kvm.snapshot.enabled is turned off (it is
enabled by default since 4.22.0.0)
Review Comment:
The comment claims kvm.snapshot.enabled has been enabled by default since
4.22.0.0, but the setting exists at least since the 4.10→4.20 schema upgrade
and is inserted with default value 'true'. The version reference is likely
misleading; consider removing the specific version and just state the default
behavior.
This issue also appears on line 1590 of the same file.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
