andrijapanicsb commented on issue #13704: URL: https://github.com/apache/cloudstack/issues/13704#issuecomment-5147719261
Thanks @weizhouapache — good fix, but I think it solves a different problem. #12651 makes CloudStack correctly *see* what IP a Windows guest already has, once it's running on KVM. This issue is about making the guest *have* the right IP in the first place — carrying the static config over from the source VM during conversion. Two practical blockers: it needs the guest agent (not guaranteed, and for cold migration the source isn't even running), and `domifaddr` only reports the current address — it can't tell us whether the guest was static or DHCP, and gives no gateway or DNS. That static-vs-DHCP distinction is the whole crux here, and it's why the `virt-v2v --mac ip:` attempt was dropped from #13656. So I'd keep #12651 as-is — it's a real fix and the two are complementary — but this one still needs the source-side config read. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
