DaanHoogland commented on PR #13659:
URL: https://github.com/apache/cloudstack/pull/13659#issuecomment-5176986528

   > @DaanHoogland I checked the classes in the file by keyword "extends 
ManagedContextRunnable"
   > 
   > * there is no try-catch in `AbstractStatsCollector`, do we need to update 
it ?
   > * some classes catch `Exception`, while others catch `Throwable` or 
`RuntimeException`. can be consistent ?
   
   I agree those would be good changes, but do they relate to this change? (or 
a new tech-debt work item?)


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to