DaanHoogland commented on PR #13644: URL: https://github.com/apache/cloudstack/pull/13644#issuecomment-5189155926
> Hello, @DaanHoogland > > > clgtm at first sight, but does backupType have a backing enum type that validation should happen against? > > No, `backupType` does not have a backing enum type, as the available backup types can change dependently of the backup provider in use. Therefore, I think it would be better to implement this in a way that allows each user to search for the backup type they need. ok, makes sense but leaves one worry; no invalidation will happen until the provider is hit. This will lead to unpredictable errors, and requires a very generic handler. I never noticed this before and is out of scope for your change! Just remarking here as a reminder (it may already be there). -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
