Dogface2k commented on code in PR #13791:
URL: https://github.com/apache/cloudstack/pull/13791#discussion_r3725444622
##########
plugins/network-elements/nsx/src/main/java/org/apache/cloudstack/service/NsxApiClient.java:
##########
@@ -489,6 +532,76 @@ public void createSegment(String segmentName, String
tier1GatewayName, String ga
}
}
+ protected String getIpDiscoveryProfilePath(String profileId) {
+ if (StringUtils.isBlank(profileId)) {
+ return null;
+ }
+ IpDiscoveryProfiles profiles = (IpDiscoveryProfiles)
nsxService.apply(IpDiscoveryProfiles.class);
+ IPDiscoveryProfile profile = profiles.get(profileId);
+ return validateProfile(profileId, profile.getId(), profile.getPath(),
"/infra/ip-discovery-profiles/", profile.getMarkedForDelete());
+ }
Review Comment:
Addressed in 0c52c26. The test now throws the VMware vAPI NotFound type from
IpDiscoveryProfiles.get(...), asserts the clean CloudRuntimeException, and
verifies that neither Segments.patch(...) nor Infra.patch(...) is called.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
