winterhazel commented on code in PR #13828:
URL: https://github.com/apache/cloudstack/pull/13828#discussion_r3775251244
##########
server/src/main/java/com/cloud/user/AccountManagerImpl.java:
##########
@@ -3274,17 +3277,17 @@ public ListResponse<ApiKeyPairResponse>
listKeys(ListUserKeysCmd cmd) {
List<ApiKeyPairResponse> responses = new ArrayList<>();
if (cmd.getKeyId() != null || cmd.getApiKeyFilter() != null) {
- fetchOnlyOneKeyPair(responses, cmd);
+ populateSingleKeyPairResponse(responses, cmd);
finalResponse.setResponses(responses);
return finalResponse;
}
- Integer total = fetchMultipleKeyPairs(responses, cmd);
- finalResponse.setResponses(responses, total);
+ populateMultipleKeyPairsResponse(responses, cmd);
+ finalResponse.setResponses(responses);
Review Comment:
@bernardodemarco this breaks pagination of `listUserKeys`, even in the UI. I
have 12 keys below, but it only shows 10.
<img width="3189" height="1813" alt="Image"
src="https://github.com/user-attachments/assets/5b56e6ca-d562-4b4c-b468-9cf8820a999e";
/>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
