github-actions[bot] commented on issue #12765: URL: https://github.com/apache/cloudstack/issues/12765#issuecomment-5294165701
## ๐ฏ Triage report `LibvirtConnection.getConnectionByVmName()` doesn't consider the VM's actual hypervisor type, so when a VM doesn't exist it silently falls back to a default connection instead of raising a clear error, producing confusing "Domain not found" messages. The reporter themselves clarified this mostly causes log noise/confusion rather than functional breakage. ### ๐ Assessment | Dimension | Value | Reasoning | |---|---|---| | **Type** | type:bug | Incorrect fallback behavior producing misleading errors, with a concrete proposed fix | | **Component** | component:kvm, component:libvirt | KVM agent's Libvirt connection resolution logic | | **Severity** | Severity:Minor | Reporter confirmed it's mainly log confusion/performance noise rather than a functional failure; no workaround needed per their own follow-up | | **Labels** | type:bug, component:kvm, component:libvirt, Severity:Minor | | | **Coding agent** | Suitable | Well-defined scope, exact file/method identified, proposed code change and list of callers to update included | ### ๐ Similar issues No duplicate or closely related open issues found. <details><summary>๐ก Notes and suggestions</summary> - Discussion also raised whether LXC support is still used/maintained; if not, a separate deprecation discussion may be warranted (weizhouapache suggested this). - Implementation should keep backward compatibility for callers not yet passing hypervisor type, as proposed in the issue. - Consider adding a unit test simulating a missing domain on both KVM and LXC connections to confirm the new exception is thrown instead of silently falling back. </details> > Generated by [Daily Issue Triage](https://github.com/apache/cloudstack/actions/runs/31806898936) ยท sonnet50 357.5K ยท [โท](https://github.com/search?q=repo%3Aapache%2Fcloudstack+%22gh-aw-workflow-call-id%3A+apache%2Fcloudstack%2Fdaily-issue-triage%22&type=issues) > <details> <summary>Add this agentic workflows to your repo</summary> To install this agentic workflow, run ``` gh aw add githubnext/agentics/workflows/daily-issue-triage.md@d7c1dc4b72b00607a67caaffdcc216cb64379cf9 ``` </details> <!-- gh-aw-agentic-workflow: Daily Issue Triage, engine: copilot, version: 1.0.52, model: claude-sonnet-5, id: 31806898936, workflow_id: daily-issue-triage, run: https://github.com/apache/cloudstack/actions/runs/31806898936 --> <!-- gh-aw-workflow-call-id: apache/cloudstack/daily-issue-triage --> -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
