github-actions[bot] commented on issue #13761: URL: https://github.com/apache/cloudstack/issues/13761#issuecomment-5356778456
## ๐ฏ Triage report CKS cluster create/start/delete on a VPC tier that has no network ACL attached yet (a valid, supported state) throws an unboxing `NullPointerException` in four locations in the CKS action-worker code, because `Network.getNetworkACLId()` (a nullable `Long`) is compared directly against primitive `long` constants. The reporter traced this back to the original KVM/VMware ingestion PR (#7976-adjacent CKS code) and confirmed it reproduces on 4.22.1.0, 4.22, and current main with a regression test. ### ๐ Assessment | Dimension | Value | Reasoning | |---|---|---| | **Type** | type:bug | Clear NPE from unboxing a nullable field, reproducible with regression tests | | **Component** | component:kubernetes, component:vpc | Affects CKS cluster lifecycle management on VPC tiers with Network ACL service | | **Severity** | Severity:Major | Breaks CKS cluster create/delete entirely on a legitimate, supported network configuration (VPC tier without an attached ACL), leaving clusters stuck in `Starting` state | | **Labels** | type:bug, component:kubernetes, component:vpc, Severity:Major | See above | | **Coding agent** | Suitable | Exact classes/methods/line numbers are identified for all four NPE sites, root cause (nullable `Long` vs primitive `long` comparison) is precisely diagnosed, and the reporter already has passing/failing regression tests distinguishing the four broken paths from 56 passing control tests | ### ๐ Similar issues No closely related open duplicates found. <details><summary>๐ก Notes and suggestions</summary> Fix should replace the four unboxing comparisons in `KubernetesClusterManagerImpl.validateVpcTier`, `KubernetesClusterResourceModifierActionWorker.createVpcTierAclRules`/`removeVpcTierAclRules`, and `KubernetesClusterStartWorker.setupKubernetesEtcdNetworkRules` with null-safe checks, letting a null ACL ID fall through to the existing `NetworkACLServiceImpl.createAclListIfNeeded` auto-create path (for create) or treat ACL cleanup as a no-op (for delete), consistent with documented CLOUDSTACK-2809 behavior. The reporter's regression tests could likely be submitted alongside a PR with minimal changes. </details> > Generated by [Daily Issue Triage](https://github.com/apache/cloudstack/actions/runs/32375697891) ยท sonnet50 224.8K ยท [โท](https://github.com/search?q=repo%3Aapache%2Fcloudstack+%22gh-aw-workflow-call-id%3A+apache%2Fcloudstack%2Fdaily-issue-triage%22&type=issues) > <details> <summary>Add this agentic workflows to your repo</summary> To install this agentic workflow, run ``` gh aw add githubnext/agentics/workflows/daily-issue-triage.md@d7c1dc4b72b00607a67caaffdcc216cb64379cf9 ``` </details> <!-- gh-aw-agentic-workflow: Daily Issue Triage, engine: copilot, version: 1.0.52, model: claude-sonnet-5, id: 32375697891, workflow_id: daily-issue-triage, run: https://github.com/apache/cloudstack/actions/runs/32375697891 --> <!-- gh-aw-workflow-call-id: apache/cloudstack/daily-issue-triage --> -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
