DaanHoogland commented on code in PR #13237:
URL: https://github.com/apache/cloudstack/pull/13237#discussion_r3823288932
##########
ui/src/views/tools/ImportUnmanagedInstance.vue:
##########
@@ -865,14 +883,26 @@ export default {
}
return 'serviceofferingdetails' in this.computeOffering ?
this.computeOffering.serviceofferingdetails.maxmemory * 1 :
Number.MAX_SAFE_INTEGER
},
+ clampCustomValue (value, min, max) {
+ if (value === undefined || value === null || isNaN(value)) {
+ return min
+ }
+ return Math.min(Math.max(value * 1, min), max)
+ },
+ getCustomCpuNumberDefault () {
+ return this.clampCustomValue(this.resource?.cpunumber, this.getMinCpu(),
this.getMaxCpu())
+ },
+ getCustomMemoryDefault () {
+ return this.clampCustomValue(this.resource?.memory, this.getMinMemory(),
this.getMaxMemory())
+ },
getCPUSpeed () {
if (!this.computeOffering) {
- return 0
+ return 2000
}
if (this.computeOffering.cpuspeed) {
return this.computeOffering.cpuspeed * 1
}
- return this.resource.cpuspeed * 1 || 0
+ return this.resource.cpuspeed * 1 || 2000
Review Comment:
good point. could also be in a tooltip.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
