DaanHoogland commented on code in PR #13940:
URL: https://github.com/apache/cloudstack/pull/13940#discussion_r3829823652
##########
server/src/main/java/com/cloud/api/query/QueryManagerImpl.java:
##########
@@ -6391,16 +6390,16 @@ public ListResponse<BackupServiceJobResponse>
listBackupServiceJobs(ListBackupSe
if (jobVO.getHostId() != null) {
response.setHostId(hostDao.findByIdIncludingRemoved(jobVO.getHostId()).getUuid());
}
- compressionJobResponses.add(response);
+ backupServiceJobResponses.add(response);
}
- responses.setResponses(compressionJobResponses, result.second());
+ responses.setResponses(backupServiceJobResponses, result.second());
return responses;
}
private Pair<List<InternalBackupServiceJobVO>, Integer>
listBackupServiceJobsInternal(ListBackupServiceJobsCmd cmd) {
return
internalBackupServiceJobDao.searchAndCountForListApi(cmd.getId(),
cmd.getBackupId(), cmd.getHostId(), cmd.getZoneId(),
- InternalBackupServiceJobType.valueOf(cmd.getType()),
cmd.getExecuting(), cmd.getScheduled(), cmd.getStartIndex(),
cmd.getPageSizeVal());
+ cmd.getType(), cmd.getExecuting(), cmd.getScheduled(),
cmd.getStartIndex(), cmd.getPageSizeVal());
Review Comment:
note that is we propagate the enum to the parameter we can use the CSoC work
by @dheeraj12347 for code completion/ parameter validation. (Last bit yet to be
designed and worked on)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
