Pearl1594 commented on code in PR #13895:
URL: https://github.com/apache/cloudstack/pull/13895#discussion_r3831767237


##########
api/src/main/java/org/apache/cloudstack/api/command/user/template/UpdateTemplateCmd.java:
##########
@@ -39,7 +39,9 @@ public class UpdateTemplateCmd extends 
BaseUpdateTemplateOrIsoCmd implements Use
     //////////////// API parameters /////////////////////
     /////////////////////////////////////////////////////
 
-    @Parameter(name = ApiConstants.TEMPLATE_TYPE, type = CommandType.STRING,
+    @Parameter(name = ApiConstants.TEMPLATE_TYPE,
+            type = CommandType.STRING,
+            allowedValues = {"USER", "VNF", "SYSTEM", "ROUTING", "BUILTIN"},

Review Comment:
   I'd probably create an enum - as these are repeated at multiple places.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to