jmsperu commented on PR #12826: URL: https://github.com/apache/cloudstack/pull/12826#issuecomment-5396229180
Pushed ab6337f: XML parsing instead of the regex, the three loops split into methods as @DaanHoogland asked, and a unit test class for the wrapper (8 tests). I've also tightened the description of what the PR guarantees (deterministic and monotonic after the last NIC, not contiguous) after Copilot's point about non-NIC devices; contiguity needs device placement at VM creation, which I'd do as a follow-up. Trillian on the previous SHA was 140 OK with one error in test_kubernetes_clusters (HA upgrade, unrelated). Would appreciate approve-and-run on the new SHA. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
