jmsperu commented on PR #12843: URL: https://github.com/apache/cloudstack/pull/12843#issuecomment-5396228514
@weizhouapache apologies for the slow reply here. The conflicts with #12822 were resolved on 28 Jul (merge of main into this branch) and the PR has been mergeable since. I've just pushed af4fbb8 for the remaining open comments: - @DaanHoogland's question on `CLEANUP_DONE`: the flag deliberately goes at the top of `cleanup()`. It marks "cleanup has been entered": cleanup() can itself `exit $EXIT_CLEANUP_FAILED`, and that exit fires the EXIT trap, which calls cleanup() again while the first call is still on the stack. Renamed to `CLEANUP_STARTED` with the comment spelling this out. - The three Copilot points (umount only if it is a mountpoint, `mount` tested directly in `if` rather than through `| tee`, `backup_stopped_vm` unmounting on success and exiting after cleanup) are already in the branch; replied on each thread. Only Sonar coverage is red, and this PR is a shell script, so there is nothing for JaCoCo to measure. Could someone approve-and-run the workflows on the new SHA? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
