jmsperu commented on PR #12898: URL: https://github.com/apache/cloudstack/pull/12898#issuecomment-5396229871
Pushed 4d919dc. The important one is Copilot's most recent point: encrypted backups could be taken but not restored, because the restore wrapper opened the qcow2 without the LUKS secret. That is now fixed end to end (details in-thread): the passphrase travels on RestoreBackupCommand, the wrapper detects an encrypted image and checks/converts with `--object secret` + `--image-opts`, file-based pools are decrypted during a qcow2 convert instead of being rsync'd, and a missing passphrase gives an explicit error. The older Copilot threads were already addressed in the branch and I've replied on each. CI on the previous SHA was fully green and Trillian passed on 22 Jun; would appreciate approve-and-run on the new SHA and a review whenever someone has time. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
