genegr commented on PR #13061: URL: https://github.com/apache/cloudstack/pull/13061#issuecomment-5467823887
Gentle bump on this one — no rush if people are away, just want to make sure it hasn't fallen off the radar. Current state, as far as I can tell nothing is outstanding from my side: - All review threads resolved (the Copilot rounds are applied; the one item I pushed back on was [confirmed fine by @DaanHoogland](https://github.com/apache/cloudstack/pull/13061#discussion_r3715037519)). - Approved by @slavkap on 27 Jul. - `build` is green. The remaining red checks are `codecov/patch`, `codecov/project`, `Sonar JaCoCo Coverage` (this adds a plugin with no unit tests, same as the other FlashArray PRs that merged) and `test_mm_domain_limits` → *"Deploy VM with specified RAM & verify the usage"*, which is resource-usage accounting and unrelated to storage. - No merge conflicts, though the branch is now ~80 commits behind `main`. I've deliberately left it alone rather than force-pushing, so as not to invalidate a regression run if one is in flight — happy to rebase the moment it's useful. @vladimirpetrov @sureshanaparti — re @DaanHoogland's question above about regression testing: is there anything you'd like from me to move that along? I have a two-host KVM lab with a FlashArray behind it and I'm glad to run any specific suite and post the results, or to add unit tests for the pure logic (EUI-128 construction/parsing, volume-path parsing) if that would help with the coverage checks. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
